Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(other): add event trigger pull_request_target to test workflows #1254

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

mahula
Copy link
Contributor

@mahula mahula commented Jun 24, 2024

🍰 Pullrequest

To automatically trigger the Github wirklfows for PRs from a fork, the trigger pull_request_target is required.

Issues

Todo

  • None

@mahula mahula added feature New feature or request good first issue Good for newcomers devops service:github labels Jun 24, 2024
@mahula mahula self-assigned this Jun 24, 2024
@mahula mahula changed the title feature(other): add event trigger pull_request_target to test workflows feat(other): add event trigger pull_request_target to test workflows Jun 24, 2024
Copy link
Contributor

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fork

I was about to say "Fine for me" until I thought: Hol'up - what about Github secrets? I was double checking the workflows and couldn't find anything serious. Interesting read: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target and considerations.

@mahula mahula merged commit 4d3c241 into master Jun 24, 2024
59 checks passed
@mahula mahula deleted the workflows-trigger-pull_request branch June 24, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops feature New feature or request good first issue Good for newcomers service:github
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants