feat(frontend): show open rooms sidebar #1273
Conversation
| @@ -3,30 +3,54 @@ | |||
| </template> | |||
|
|
|||
| <script lang="ts"> | |||
| import { defineComponent, provide } from 'vue' | |||
| import { DefaultApolloClient } from '@vue/apollo-composable' | |||
| import { defineComponent, provide } from 'vue' | |||
There was a problem hiding this comment.
Unintended indent change?
There was a problem hiding this comment.
I noticed that /storybook is in .eslintignore, I don't see why and suggest we change it.
| import Circle from './CircleElement.vue' | ||
| import LightDarkSwitch from './LightDarkSwitch.vue' | ||
| import LogoImage from './LogoImage.vue' | ||
| import TabControl from './TabControl.vue' | ||
| import UserInfo from './UserInfo.vue' | ||
|
|
||
| const drawer = ref(false) |
There was a problem hiding this comment.
"Just" naming, but I have a strong preference for isDrawerVisible, or maybe showDrawer. I figured that Vuetify internally calls this drawer as well, but that doesn't make it a better name imo.
| const emits = defineEmits(['update:modelValue']) | ||
| const internalValue = ref(props.modelValue) | ||
| watch(internalValue, (newValue) => { | ||
| emits('update:modelValue', newValue) | ||
| }) | ||
| watch( | ||
| () => props.modelValue, | ||
| (newValue) => { | ||
| internalValue.value = newValue | ||
| }, | ||
| ) |
There was a problem hiding this comment.
| const emits = defineEmits(['update:modelValue']) | |
| const internalValue = ref(props.modelValue) | |
| watch(internalValue, (newValue) => { | |
| emits('update:modelValue', newValue) | |
| }) | |
| watch( | |
| () => props.modelValue, | |
| (newValue) => { | |
| internalValue.value = newValue | |
| }, | |
| ) | |
| const internalValue = defineModel<string>() |
| @@ -0,0 +1,69 @@ | |||
| <template> | |||
There was a problem hiding this comment.
IMO this could be merged with ListElement.vue to RoomList.vue and we could remove a lot of code.
Otherwise:
- Remove in fact unused location property
- Use defineModel() syntax
- Rename
drawerto something more meaningful
|
I can't comment in the code, because there was no change. But in |
| .create-button-mobile { | ||
| z-index: 1; | ||
| transform: translate(20px, 30px); | ||
| } |
There was a problem hiding this comment.
Oh, I think this should not be here.
There was a problem hiding this comment.
You are right if this is needed it should be in an own PR.
Merge master and resolve conflicts. remove timeout for refetch rooms silent refresh without default layout no default lazyut on auth page more logs, use setRooms to update state delay refetch open rooms 1 min, more console to debug console to debug linting error handling refetch open rooms handle click event on open room type startTime in Room/OpenRoom is string quick and dirty fixing of List Drawer, open rooms query, rooms store Add rooms store. Merge branch 'master' into 709-6-Toggle-In-TopMenu Update snapshots. Fix linting Add function of ListNavigationDrawer. Test remove handleOpenRooms. fix style Merge branch 'master' into 709-6-Toggle-In-TopMenu fix eslint remove space lint fix resolve conflicts remove render files remove only from test resolve conflicts change classname fix test, fix lint resolve conflicts fix test and lint and update add snapshot resolve conflicts, remove Navigatin Drawer Component remove unused prop Update frontend/src/components/vuetify/NavigationDrawer.vue Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de> Update frontend/src/components/vuetify/NavigationDrawer.vue Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de> add snapshots remove unused file add locale, change tsconfig coverage to 96% Merge branch 'master' into 709-6-Toggle-In-TopMenu Merge branch 'master' into 709-6-Toggle-In-TopMenu fix lint add snapshots, ??render config??? add toggle on camera icon, open sibebar fix lint, fix test clear imports Add Snapshots clear imports Merge branch '709-7-SearchField-Component' into 709-4-ListWithNavigationDrawer-Component Add Snapshot, fix lint Add SearchField Component fix clear imports change files and folders for atomic design add ListWithNavigationDrawer Component, change files and folders for atomic design Merge branch '709-5-NavigationDrawer-Component' into 709-4-ListWithNavigationDrawer-Component fix test add snapshot fix lint NavigationDrawer Component fix test and lint Add ListElement Component
🍰 Pullrequest
Issues
Todo