refactor(other): run remark from root folder only #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- This is a side quest from #1321. Since #1317 we lint markown files from the root folder. It makes no sense to run it again and again from each subfolder. Benefits: * Less dependencies * Faster CI because of: * `npm install` * `npm run test:lint` * Faster deployment How to test ----------- 1. See build checks
Mogge
requested changes
Jul 3, 2024
There was a problem hiding this comment.
The rules are not the same. E.g. I run tests in frontend on master and get not errors/warnings. I run the tests in main directory on your branch and I get this warnings:
frontend/README.md
warning Incorrect list-item indent style `one`: use either `'tab-size'`, `'space'`, or `'mixed'` list-item-indent remark-lint
|
@Mogge can you |
Mogge
approved these changes
Jul 3, 2024
mahula
reviewed
Jul 3, 2024
| @@ -26,8 +26,7 @@ | |||
| "test": "npm run test:lint", | |||
| "docs:dev": "vuepress dev .", | |||
| "docs:build": "vuepress build .", | |||
| "release": "scripts/release.sh", | |||
| "update": "npx npm-check-updates" | |||
There was a problem hiding this comment.
Why was that remove? And why in this pull request? And why has this change been approved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a side quest from #1321.
Since #1317 we lint markown files from the root folder. It makes no sense to run it again and again from each subfolder.
Benefits:
npm installnpm run test:lintHow to test