-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(workflow): dry dependabot.yml #1381
Conversation
bb67355
to
a79077d
Compare
It looks as if this change will have the desired behavior:
But there is no option to check the dependabot configuration before it lands in I will draft this PR and check the configuration on a copy of this repository. |
5f85353
to
8bb3e84
Compare
I changed the Dependabot file in a fork. It partly works as expected, but not at 100 % (see https://github.com/mahula/dreammall.earth/pulls). |
4968aae
to
4b559c1
Compare
Motivation ---------- I was looking into configuration for dependabot to update the same package across multiple `package.json`s and found the [`directories` option](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#directories) My goal is to update e.g. `vue` *across all subfolders* to the same version. You can check our PR list and see that the same dependency is updated separately for each folder, which is the culprit of our many dependanbot PRs. Nevertheless, even if we don't see this behaviour, it's good to DRY our configuration files. How to test ----------- 1. Merge this PR 2. See if dependabot updates the same package across several directories
4b559c1
to
e0626c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes work fine (see this fork)
Motivation
I was looking into configuration for dependabot to update the same package across multiple
package.json
s and found thedirectories
optionMy goal is to update e.g.
vue
across all subfolders to the same version. You can check our PR list and see that the same dependency is updated separately for each folder, which is the culprit of our many dependanbot PRs.Nevertheless, even if we don't see this behaviour, it's good to DRY our configuration files.
How to test