feat(workflow): auto-assign PR author #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahula
approved these changes
Jul 10, 2024
mahula
changed the title
roschaefer
force-pushed
the
auto-assign-pr-author
branch
from
ada7a0b to
04f533a
Compare
Elweyn
approved these changes
Jul 10, 2024
Motivation ---------- I've heard today that we want to assign each PR to its respective author, so the name appears in the PR list on the right side: https://github.com/dreammall-earth/dreammall.earth/pulls I keep forgetting this, so I'd say let's drop the requirement or automate this. Feel free to reject this PR in case we drop the requirement. How to test ----------- 1. Merge this into `master` 2. See if new PRs get auto-assigned
roschaefer
force-pushed
the
auto-assign-pr-author
branch
from
ad2ea95 to
b49867d
Compare
1 task
roschaefer
added a commit
that referenced
this pull request
Jul 10, 2024
Motivation ---------- #1388 was the third PR that ran into a complexity of `pull_request_target`: Since the `root.yml` workflow would run on the base branch where the changes to `auto-assign` was not present, the new workflow was not tested. How to test ----------- 1. We need admin powers to merge this, as it will turn red 2. After merge, new PRs should be green again
roschaefer
added a commit
that referenced
this pull request
Jul 10, 2024
Motivation ---------- #1388 was the third PR that ran into a complexity of `pull_request_target`: Since the `root.yml` workflow would run on the base branch where the changes to `auto-assign` was not present, the new workflow was not tested. How to test ----------- 1. We need admin powers to merge this, as it will turn red 2. After merge, new PRs should be green again
Elweyn
added a commit
that referenced
this pull request
Jul 11, 2024
Motivation ---------- #1388 was the third PR that ran into a complexity of `pull_request_target`: Since the `root.yml` workflow would run on the base branch where the changes to `auto-assign` was not present, the new workflow was not tested. How to test ----------- 1. We need admin powers to merge this, as it will turn red 2. After merge, new PRs should be green again Co-authored-by: Hannes Heine <heine.hannes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I've heard today that we want to assign each PR to its respective author, so the name appears in the PR list on the right side: https://github.com/dreammall-earth/dreammall.earth/pulls
I keep forgetting this, so I'd say let's drop the requirement or automate this.
Feel free to reject this PR in case we drop the requirement.
How to test
master