Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Implement *_Precache_*, ClientPrintf, CheckUserInfo and AddResource hooks #903

Merged
merged 49 commits into from
Sep 19, 2022
Merged

API: Implement *_Precache_*, ClientPrintf, CheckUserInfo and AddResource hooks #903

merged 49 commits into from
Sep 19, 2022

Conversation

ShadowsAdi
Copy link
Contributor

@ShadowsAdi ShadowsAdi commented Mar 5, 2022 •
edited
Loading

  • PF_precache_generic_I
  • PF_precache_model_I
  • PF_precache_sound_I
  • SV_CheckUserInfo
  • SV_AddResource
  • EV_Precache
  • SV_ClientPrintf

Resource hooks related to #248
SV_CheckUserInfo #238
SV_ClientPrintf #903

@ShadowsAdi
Added SV_CheckUserInfo hook
6dff682
@ShadowsAdi
Fixed an error
c4c4e82
@ShadowsAdi
Update build.yml
97a8565
@ShadowsAdi
Update build.yml
20d8d10
@ShadowsAdi
Update build.yml
e0d2455
@ShadowsAdi
Fixed function's defs positioning
a5a4bc2
@ShadowsAdi
Implemented PF_precache_* hooks
fda7f7e 
- PF_precache_sound_I
- PF_precache_model_I
- PF_precache_generic_I
@ShadowsAdi
Merge branch 'master' into precache-hooks
cd03d01
@ShadowsAdi
Testing EXT_FUNC
422fd60
@ShadowsAdi
Merge branch 'precache-hooks' of https://github.com/ShadowsAdi/rehlds …
3719c5f 
…into precache-hooks
@ShadowsAdi
Update pr_cmds.cpp
46130dd
@ShadowsAdi
Update pr_cmds.cpp
019141a
@ShadowsAdi
Test without const
7a842cc
@ShadowsAdi
Update eiface.h
2afe585
@ShadowsAdi
Update pr_cmds.cpp
caa778f
@ShadowsAdi
Revert "Update pr_cmds.cpp"
a10dd39 
This reverts commit 019141a.
@ShadowsAdi
Revert const changes
ea17a1e
@ShadowsAdi
Update pr_cmds.cpp
d61cf70
@ShadowsAdi
Update eiface.h
88f37a1
@ShadowsAdi
Update pr_cmds.cpp
fc49dae
@ShadowsAdi
Update pr_cmds.cpp
319cb33
@ShadowsAdi

This comment was marked as resolved.

Sign in to view
@StevenKal
Copy link
Contributor

StevenKal commented Mar 5, 2022 •
edited
Loading

I remember tried memhack hook those functions, & one of them was "fucked up under ReHLDS", as usual with it, unfortunately...
So it is a safe & welcomed PR.

Well, the fact you implemented "SV_CheckUserInfo" inside this PR, and the other fact this PR contains multiple hooks, I think you can close your other one for simplicity. But add you added it too, in the description.
Also, in order to have something "almost complete about precaching stuff", it will be nice if you could also add "EV_Precache" (precache_event) & "SV_AddResource" to your PR. Thanks in advance!

EDIT: Also, think to update "API minor" (+1) in the two files ("version.h" & "rehlds_api.h").

@ShadowsAdi ShadowsAdi mentioned this pull request Mar 5, 2022
Closed
@ShadowsAdi ShadowsAdi changed the title Implemented PF_Precache_* hooks Implemented PF_Precache_* and SV_CheckUserInfo hooks Mar 5, 2022
@ShadowsAdi
Added EV_Precache and SV_AddResource hooks
9c11a46 
and update API minor version
@ShadowsAdi ShadowsAdi changed the title Implemented PF_Precache_* and SV_CheckUserInfo hooks Implemented Precache_*, SV_AddResource and SV_CheckUserInfo hooks Mar 5, 2022
@StevenKal
Copy link
Contributor

StevenKal commented Mar 5, 2022 •
edited
Loading

Nice! Now I think we could submit other hooks requests to it! Hehehe!
Let's hope approvers will not be in panic! Even if I think it is simpler to have all-in-one.

Without abusing, I am thinking of "SV_ClientPrintf" (similar to "Con_Printf", but send to client [like when you type in-game some commands as "status", this uses this one], so very useful, you can put it in top of the list below "its friend"!), "Sys_Error" & "Host_Error" too (useful to prevent server crash on an error which may not be "critical for it", or, if we use an internal code to fix, as example I have a map where I have a "Bad surface extents ..." error shit, so I could not run it, then I blocked the function, map runs fine & I did not constated third-party troubles!).
There are other functions, but as I said, I do not want to abuse with your time & devotion!

I guess you could rename the PR into "Implemented more hooks"! With such listing!

PS: I do not recommend to make the functions from the structure "RehldsFuncs_t" (g_RehldsApiFuncs) point to another "redirected function" (like now "SV_AddResource_api"), except if there is a conflit somewhere while compiling, or, if you add additionnal code inside that famous "_api" function. Mainly due to the fact we loose the possibility to get the address of the "real function", via this structure (& by using "g_RehldsApiFuncs" as base address).

@SergeyShorokhov
Copy link
Member

remove all refactoring from this PR please

@ShadowsAdi
Copy link
Contributor Author

Everything should be alright now, @wopox1337

@UnrealKaraulov
Copy link

Any news ? 👀

Nice feature, please merge it! :)

@StevenKal
Copy link
Contributor

StevenKal commented Jul 26, 2022 •
edited
Loading

Any news ? 👀

Nice feature, please merge it! :)

Yes, nice feature. But corpses everywhere nowadays! All fucking dead! Disappointing huh!
Population in the world keeps increasing, but it seems Aliens have kidnapped a lot of people to bring them "we do not know where"!

@RauliTop
Copy link
Contributor

Yes, nice feature. But corpses everywhere nowadays! All fucking dead! Disappointing huh! Population in the world keeps increasing, but it seems Aliens have kidnapped a lot of people to bring them "we do not know where"!

Where place did you escape from?

@StevenKal
Copy link
Contributor

I am one of the aliens (other group of aliens), I can not reveal secret defense information about possible location of others aliens lab!

@SergeyShorokhov SergeyShorokhov merged commit d6ebe82 into rehlds:master Sep 19, 2022
@SergeyShorokhov SergeyShorokhov added Engine: 📀 reHLDS Case refers to reHLDS engine. Priority: 🕒 low Low priority tasks that can be postponed for the future. Type: 🚀 enhancement Improvement or addition of a new feature. Status: ✅ done The issue done and closed. labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenKal StevenKal StevenKal left review comments

@LevShisterov LevShisterov LevShisterov left review comments

@SergeyShorokhov SergeyShorokhov SergeyShorokhov approved these changes

Assignees

@SergeyShorokhov SergeyShorokhov

@ShadowsAdi ShadowsAdi

Labels
Engine: 📀 reHLDS Case refers to reHLDS engine. Priority: 🕒 low Low priority tasks that can be postponed for the future. Status: ✅ done The issue done and closed. Type: 🚀 enhancement Improvement or addition of a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ShadowsAdi @StevenKal @SergeyShorokhov @UnrealKaraulov @RauliTop @LevShisterov