pkg: plasma: plasma-dialer: remove qt6-quickcontrols2 dependency #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to bump pkgrel. |
|
Sorry about that, I bumped it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The qt6-quickcontrols2 package has been integrated into the qt6-declarative package. Therefore, it should be removed as a dependency for the plasma-dialer package.
Supporting links:
https://github.com/qt/qtquickcontrols2?tab=readme-ov-file
https://bugreports.qt.io/browse/QTBUG-79454
https://wiki.qt.io/QtCS2021_-_Testing_upstream_changes_with_downstream_modules
This resolves issue #668
Once I removed the dependency, plasma-dialer built successfully on my x86_64 machine running Arch Linux.
I have done my best to adhere to the contribution guidelines. Hopefully I did not miss anything.