Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL tokens are not sanitised well #132

Closed
AlexSkrypnyk opened this issue Nov 4, 2024 · 0 comments · Fixed by #145
Closed

URL tokens are not sanitised well #132

AlexSkrypnyk opened this issue Nov 4, 2024 · 0 comments · Fixed by #145

Comments

@AlexSkrypnyk
Copy link
Member

http%3A%2F%2Fexample\.com%3A8888%2Fscreenshot.html%3Ffoo%3Dtest-foo%23foo-fragment.png - this is not a good file name created from token.

We need to cleanup urlencoded items by default (replace with underscore) and introduce raw to use the original if still required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#132] Replaced URL-encoded characters in the screenshot file names. drevops/behat-screenshot
1 participant
@AlexSkrypnyk