Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated encodestring #56

Closed
martialblog opened this issue Mar 18, 2020 · 2 comments
Closed

Replace deprecated encodestring #56

martialblog opened this issue Mar 18, 2020 · 2 comments
Assignees
@martialblog
Milestone
v2.0

Comments

@martialblog
Copy link
Collaborator

While adding pylint to the CI, I notices that encodestring() is used.

check_http_json.py:589:24: W1505: Using deprecated method encodestring() (deprecated-method)

@martialblog martialblog added this to the v2.0 milestone Mar 18, 2020
@martialblog martialblog self-assigned this Mar 18, 2020
@martialblog
Copy link
Collaborator Author

The current code doesn't work as is in Python3 at all.

martialblog added a commit that referenced this issue Mar 18, 2020
@martialblog
Replace deprecated encodestring
dd952fd 
 - Fixes #56
@martialblog
Copy link
Collaborator Author

Fixed in 2.0

https://github.com/drewkerrigan/nagios-http-json/tree/v2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martialblog martialblog

Labels
None yet
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
1 participant
@martialblog