Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate bodylength and checksum #13

Merged

Conversation

whatthefrog
Copy link
Collaborator

Hi,

I have added an automated validation feature to your fix-decoder tool.
It checks both the BodyLength(9) and the Checksum(10) against the values given in the FIX messages, and colorise the fields in green if valid, or red if invalid, given the expected value at the same time.

image

I use your tool often, and got stuck one day doing testing, because I wasn't sending the correct length building some FIX messages by hand, not the best idea to start with agreed, but I thought it would be a nice addition to nice tool.

Best

Julien

…the one given in FIX field BodyLength(9)

Also put correct values in the examples
… the FIX message

Also put correct checksums in the examples
@drewnoakes
Copy link
Owner

Fantastic stuff.

Would you like to be added as a collaborator on this repo?

drewnoakes added a commit that referenced this pull request Mar 15, 2015
@drewnoakes drewnoakes merged commit 237029f into drewnoakes:master Mar 15, 2015
@whatthefrog
Copy link
Collaborator Author

Afternoon, thanks for the merge.
Adding me as a collaborator, why not ? not sure what that involves, being quite new to github specifically and open source contributions in general. So far I can only think of one thing: add a little navigation resume on the top left, to give an overview of the dialog ... but this is a bit of work.

@drewnoakes
Copy link
Owner

Great. You're a collaborator now which means you can now push freely to the repo. I trust your judgement completely.

@whatthefrog
Copy link
Collaborator Author

Thanks, that was a rewarding contribution then ;-)
I will keep proposal in feature branches but form your repo then, and submit pull requests the same way so we can discuss details, if needed, before merging to master then ...

@drewnoakes
Copy link
Owner

If you'd rather produce feature branches, that's fine. I'm happy with whatever works best for you.

@whatthefrog whatthefrog mentioned this pull request Apr 26, 2017
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants