Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed parsing of illegal dates + handle known null value #650

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Fixed parsing of illegal dates + handle known null value #650

merged 1 commit into from
Feb 4, 2024

Conversation

StefanOltmann
Copy link
Contributor

Fixes the problem that parsing a date like 0000:00:00 00:00:00 will become Sun Nov 30 00:00:00 GMT 2.

Resolves #609.

drewnoakes
drewnoakes approved these changes Feb 4, 2024
View reviewed changes
Copy link
Owner

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks.

Running your branch over the regression test data doesn't show any difference. Is there an image that triggers this for you that we can add for testing? The content of the image is not important, just the metadata.

@drewnoakes drewnoakes merged commit 753cf1f into drewnoakes:master Feb 4, 2024
5 checks passed
@StefanOltmann StefanOltmann deleted the fix_date_parsing branch February 4, 2024 07:07
@StefanOltmann
Copy link
Contributor Author

@drewnoakes Yes, I attached on the original issue a JPG test image you are free to use in your repository.

#609 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewnoakes drewnoakes drewnoakes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EXIF DateTimeOriginal: Properly handle "0000:00:00 00:00:00"
2 participants
@StefanOltmann @drewnoakes