Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor willReceiveProps usages into getDerivedStateFromProps #129

Merged
merged 7 commits into from
Nov 7, 2019
Merged

Refactor willReceiveProps usages into getDerivedStateFromProps #129

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0f0c9fb
Remove extraneous args
tstirrat15 Oct 21, 2019
e32eaee
Put logic that was previously in willReceiveProps into didUpdate
tstirrat15 Oct 21, 2019
7af970c
Fix comment
tstirrat15 Oct 21, 2019
07eb917
Fix typo
tstirrat15 Oct 24, 2019
9183fec
Use gDSP instead
tstirrat15 Nov 4, 2019
6bb375f
Revert chnages to cDU
tstirrat15 Nov 4, 2019
2f4d400
Fix getDerivedStateFromProps to not reference this
tstirrat15 Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Rating.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ class Rating extends React.PureComponent {
this.symbolClick = this.symbolClick.bind(this);
}

UNSAFE_componentWillReceiveProps(nextProps) {
const valueChanged = this.props.value !== nextProps.value;
this.setState((prevState) => ({
displayValue: valueChanged ? nextProps.value : prevState.displayValue
}));
static getDerivedStateFromProps(props, prevState) {
const { value } = props;
return (value === prevState.displayValue)
? { displayValue: value }
: null;
}

componentDidUpdate(prevProps, prevState) {
Expand Down
9 changes: 5 additions & 4 deletions src/RatingAPILayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ class RatingAPILayer extends React.PureComponent {
this.handleHover = this.handleHover.bind(this);
}

UNSAFE_componentWillReceiveProps(nextProps) {
this.setState({
value: nextProps.initialRating
});
static getDerivedStateFromProps(props, prevState) {
const { initialRating } = this.props;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups. this.props -> props
So used to write always together...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ good catch.

return (initialRating !== prevState.value)
? { value: initialRating }
: null;
}

handleClick(value, e) {
Expand Down
6 changes: 3 additions & 3 deletions test/Rating-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,20 +60,20 @@ describe('Rating', function () {
});

it('should have all symbols readonly', function () {
rating.props.children.forEach(function (symbol, i) {
rating.props.children.forEach(function (symbol) {
expect(symbol.props.readonly).to.be.false;
});
});
it('should not have mouse move handler', function () {
var noop = require('../src/utils/noop');
rating.props.children.forEach(function (symbol, i) {
rating.props.children.forEach(function (symbol) {
expect(symbol.props.onMouseMove).to.equal(noop);
});
});

it('should not have click handler', function () {
var noop = require('../src/utils/noop');
rating.props.children.forEach(function (symbol, i) {
rating.props.children.forEach(function (symbol) {
expect(symbol.props.onClick).to.equal(noop);
});
});
Expand Down