New Rule to use the whereLike clause in Laravel 11.x
#267
Conversation
| if (! $this->isObjectType($node->var, new ObjectType('Illuminate\Database\Query\Builder'))) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
You would be better off expanding this a little. Namely using the contract for the query builder instead of the object type.
| */ | ||
| public function getNodeTypes(): array | ||
| { | ||
| return [MethodCall::class]; |
There was a problem hiding this comment.
This could be expanded to Static calls for a Model as well, as Model::where('a', 'like', 'b') wouldn't be covered by this rule as it uses a proxy system.
|
|
||
| use Illuminate\Database\Query\Builder; | ||
|
|
||
| class Fixture |
There was a problem hiding this comment.
It's best not to name classes in tests the same. I've found it causes weird issues. It's best to name the class WithPostgresDriver to match the file name.
| return; | ||
| } | ||
|
|
||
| Assert::count($configuration, 1); |
There was a problem hiding this comment.
this line seems a bit redundant as we know it's an array and the key is checked. It should affect anything if the config contains more keys
| Assert::keyExists($configuration, 'usingPostgresDriver'); | ||
| Assert::boolean($configuration['usingPostgresDriver']); | ||
| $this->usingPostgresDriver = $configuration['usingPostgresDriver']; |
There was a problem hiding this comment.
It might be useful to introduce a const for the array key that's public or just have a static method that creates the array e.g. WhereToWhereLikeRector::usingPostgresDriver() Then update the code sample for it.
Adds a new rule
WhereToWhereLike(open for a better name) that will migrate all the->where('name', 'like', '%Rector%')clauses into the newwhereLike()introduced in Laravel 11.x.