Remove null coalesce for methods with default argument #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
The rule should be useful to reduce the use of null coalescing with methods and functions where the method can take a default argument.
Not that in some cases a null coalescing might still be needed, for instance, if a config key is set to null, as far as I'm aware, it would still return null over the default. The default is only used when a key is missing.
The rule also covers the scenario where null is set and removes it.