Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate failover provider #15

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Integrate failover provider #15

merged 2 commits into from
Oct 15, 2024

Conversation

jtourkos
Copy link
Contributor

@jtourkos jtourkos commented Oct 3, 2024 •
edited
Loading

Tested with Safe as well.

@jtourkos jtourkos requested a review from efstajas October 3, 2024 19:35
@jtourkos jtourkos mentioned this pull request Oct 4, 2024
Closed
5 tasks
efstajas
efstajas approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@efstajas efstajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe consider copying over the (minor) suggestions to FailoverProvider from the app PR here too, but not a blocker if not.

Base automatically changed from multi-chain-api-support to main October 9, 2024 11:54
@jtourkos jtourkos merged commit 9afd7a2 into main Oct 15, 2024
@railway-app railway-app bot requested a deployment to app-pr-1260 October 15, 2024 10:39 Abandoned
@railway-app railway-app bot requested a deployment to app-pr-1263 October 15, 2024 10:39 Abandoned
@railway-app railway-app bot requested a deployment to app-pr-1262 October 15, 2024 10:39 Abandoned
@jtourkos jtourkos deleted the integrate-failover-provider branch October 15, 2024 10:45
@railway-app railway-app bot requested a deployment to app-pr-1264 October 15, 2024 13:45 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efstajas efstajas efstajas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtourkos @efstajas