first home task #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
October 2, 2018 20:58
Green Signed-off-by: Alexander Potapov <potapov.alexander@dev.local>
Krestol
reviewed
Oct 10, 2018
| } | ||
| return 0; | ||
| return -1; |
There was a problem hiding this comment.
нет теста, покрывающего эту строку
Krestol
reviewed
Oct 10, 2018
| @@ -19,13 +19,26 @@ If your language provides a method in the standard library to perform the conver | |||
|
|
|||
| #include <gtest/gtest.h> | |||
|
|
|||
| int DemicalView(std::string str) | |||
There was a problem hiding this comment.
На этом шаге выполнялся рефакторинг или написание кода?
Krestol
reviewed
Oct 10, 2018
| int answer = 0; | ||
| answer += OneSignDemicalView(str.substr(str.size() - 1 , 1)); | ||
|
|
||
| return (answer > 0)? answer : 0; |
There was a problem hiding this comment.
нет теста, проверяющего поведение при answer <= 0
Krestol
reviewed
Oct 10, 2018
| @@ -68,3 +68,9 @@ TEST(TernaryNumbers, TwoSignString11) | |||
| { | |||
| ASSERT_EQ(4, DemicalView("11")); | |||
| } | |||
|
|
|||
|
|
|||
| TEST(TernaryNumbers, SpecifcationTest) | |||
There was a problem hiding this comment.
В спецификации есть еще ожидаемое поведение при воде невалидной строки. На это нет тестов.
added 5 commits
October 17, 2018 09:53
Signed-off-by: Alexander Potapov <potapov.alexander@dev.local>
Signed-off-by: Alexander Potapov <potapov.alexander@dev.local>
Signed-off-by: Alexander Potapov <potapov.alexander@dev.local>
Signed-off-by: Alexander Potapov <potapov.alexander@dev.local>
Signed-off-by: PotapovAlexandr <alexpotapov1985@gmail.com>
Signed-off-by: PotapovAlexandr <alexpotapov1985@gmail.com>
Signed-off-by: Alexander Potapov <potapov.alexander@dev.local>
Signed-off-by: Alexander Potapov <potapov.alexander@dev.local>
Signed-off-by: Alexander Potapov <potapov.alexander@dev.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.