Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pg] FIX: correct string escaping for empty PgArrays #1640

Merged
merged 4 commits into from
Dec 20, 2023
Merged

[Pg] FIX: correct string escaping for empty PgArrays #1640

merged 4 commits into from
Dec 20, 2023

Conversation

Angelelz
Copy link
Collaborator

Closes #878

  • Added handling of empty string edge case
  • Added unit test to the parsing function
  • Added integration test to both node-pg and postgres.js

@AndriiSherman AndriiSherman changed the base branch from main to beta December 15, 2023 11:54
@AndriiSherman AndriiSherman merged commit 933d2d6 into drizzle-team:beta Dec 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriiSherman AndriiSherman Awaiting requested review from AndriiSherman

Assignees
No one assigned
Labels
ready-to-be-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: pgArray generates invalid SQL when an array includes an empty string
2 participants
@Angelelz @AndriiSherman