-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix neon serverless generic #1946
Fix neon serverless generic #1946
Conversation
I think it's better if we fix the underlying |
@@ -42,12 +42,11 @@ | |||
"bugs": { | |||
"url": "https://github.com/drizzle-team/drizzle-orm/issues" | |||
}, | |||
"homepage": "https://github.com/drizzle-team/drizzle-orm#readme", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two homepage
entries. You can see it on main. pnpm automatically removed one, I think. I will add the duplicate back and leave it to you guys to fix :)
"peerDependencies": { | ||
"@aws-sdk/client-rds-data": ">=3", | ||
"@cloudflare/workers-types": ">=3", | ||
"@libsql/client": "*", | ||
"@neondatabase/serverless": ">=0.1", | ||
"@neondatabase/serverless": ">=0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not, again I think pnpm
added the zero when I did --save-peer
. Will revert to 0.1
.
@dankochetov, agree on the correct fix. I don't have much bandwidth to dive into it, and since I'm not familiar with both codebases it could take a while so if you folks have time I'd ignore this PR. |
Fixed in #2033. |
Fix, albeit maybe not optimal, for #1945