Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix neon serverless generic #1946

Closed

Conversation

evanshortiss
Copy link

Fix, albeit maybe not optimal, for #1945

@dankochetov
Copy link
Contributor

I think it's better if we fix the underlying NeonQueryFunction type (or, even better, reuse that type from Neon SDK rather than re-declaring it). NeonQueryFunction<false, false> should be assignable to NeonQueryFunction<boolean, boolean>.

@@ -42,12 +42,11 @@
"bugs": {
"url": "https://github.com/drizzle-team/drizzle-orm/issues"
},
"homepage": "https://github.com/drizzle-team/drizzle-orm#readme",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two homepage entries. You can see it on main. pnpm automatically removed one, I think. I will add the duplicate back and leave it to you guys to fix :)

"peerDependencies": {
"@aws-sdk/client-rds-data": ">=3",
"@cloudflare/workers-types": ">=3",
"@libsql/client": "*",
"@neondatabase/serverless": ">=0.1",
"@neondatabase/serverless": ">=0.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not, again I think pnpm added the zero when I did --save-peer. Will revert to 0.1.

@evanshortiss
Copy link
Author

@dankochetov, agree on the correct fix. I don't have much bandwidth to dive into it, and since I'm not familiar with both codebases it could take a while so if you folks have time I'd ignore this PR.

@dankochetov
Copy link
Contributor

Fixed in #2033.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants