Fix return of large Youtube thumbnail (#12)

drmonkeyninja · Feb 9, 2018 · 070bb3f · 070bb3f
1 parent 6a0acec
commit 070bb3f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/View/Helper/VideoHelper.php b/src/View/Helper/VideoHelper.php
@@ -448,7 +448,7 @@ public function youtubeThumbnail($url, $size = 'thumb', $options = [])
             'maxres' => 'maxresdefault'
         ];
 
-        if (empty($acceptedSizes[$size]) === true) {
+        if (! isset($acceptedSizes[$size]) === true) {
             return;
         }
 

diff --git a/tests/TestCase/View/Helper/VideoHelperTest.php b/tests/TestCase/View/Helper/VideoHelperTest.php
@@ -63,4 +63,9 @@ public function testYouTubeThumbnail()
         $expected = '';
         $this->assertEquals($expected, $this->Video->youtubeThumbnail('https://www.youtube.com/watch?v=heNGFmEQVq0', 'small'));
     }
+
+    public function testYouTubeThumbnailCanReturnLargeImage() {
+        $expected = '<img src="//i.ytimg.com/vi/heNGFmEQVq0/0.jpg" alt=""/>';
+        $this->assertEquals($expected, $this->Video->youtubeThumbnail('https://www.youtube.com/watch?v=heNGFmEQVq0', 'large'));
+    }
 }