Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[디자인] 디자인 최신화 #320

Merged
merged 11 commits into from
Jun 3, 2024
Merged

Conversation

JeonK1
Copy link
Contributor

@JeonK1 JeonK1 commented Jun 2, 2024

Issue

Overview (Required)

  • figma 디자인과 상이한 부분들이 있어서 이들을 일치시키는 작업을 진행하였습니다.
  • Bookmark 는 Dark Mode 및 편집 관련 기능이 적용되어있지 않아서 세세한 추가는 제외하였습니다.

Links

Copy link

github-actions bot commented Jun 2, 2024

Test Results

18 tests   18 ✅  5s ⏱️
11 suites   0 💤
11 files     0 ❌

Results for commit d74dd83.

@Preview
@Composable
private fun IconTextChipPreview() {
MaterialTheme {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview에서는 theme를 적용하지 않고, @Preveiw 어노테이션을 활용하여 처리할수도 있습니다.
개인적으론 preview용 theme를 따로 만들어 사용하기도 합니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후 컴포즈 개발에도 참고해야겠네요! 코멘트 감사드립니다~

@taehwandev
Copy link
Member

확인 감사합니다!

@taehwandev taehwandev merged commit 4799141 into droidknights:main Jun 3, 2024
2 checks passed
@taehwandev taehwandev added the 2024 label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[디자인] 디자인 최신화
2 participants