Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[개선] 분리한 컴포넌트 preview 작성 #329

Conversation

tmdgh1592
Copy link
Contributor

Issue

Overview (Required)

PR 쪼개기 마지막입니다..!

  • 이전 PR에서 분리한 컴포넌트에 대한 Preview를 작성하였습니다.

Screenshot

ContributorCard Preview ContributorTopBanner Preview

Copy link

github-actions bot commented Jun 8, 2024

Test Results

20 tests   20 ✅  19s ⏱️
11 suites   0 💤
11 files     0 ❌

Results for commit 160d21a.

@@ -58,3 +63,45 @@ internal fun EditModeLeadingItem(
)
}
}

private val SampleBookmarkItemUiState = BookmarkItemUiState(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

참고로 이런 경우는 사용하시면 됩니다.
https://developer.android.com/develop/ui/compose/tooling/previews#preview-data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다
PreviewParameterProvider를 사용하면 샘플 데이터를 따로 관리할 수 있었겠네요 🤔

@taehwandev taehwandev merged commit 4d2455e into droidknights:main Jun 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[개선] UI 파일을 단위별로 분리해봅니다.
2 participants