[Contributor] 컨트리뷰터 화면 UI 컴포넌트 구현 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#34 머지된 이후에 리뷰 요청 예정 |
Pluu
reviewed
Jul 12, 2023
.../contributor/src/main/java/com/droidknights/app2023/feature/contributor/ContributorScreen.kt
Show resolved
Hide resolved
taehwandev
reviewed
Jul 13, 2023
| .align(Alignment.CenterEnd), | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Scaffold + TopAppBar를 함께 사용하면 쉽게 해결가능하긴해요.
요건 제가 적용해볼게요.
There was a problem hiding this comment.
@taehwandev @wisemuji
이 코멘트를 늦게 봤는데 아래 PR에서 추가 논의 해도 좋을 것 같습니다.
Pluu
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Etc.
디자이너와의 소통이 필요하여 별도의 이슈로 진행할 TODO입니다.
Screenshot