Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Contributor] 카드 UI 변경 #97

Merged
merged 3 commits into from
Jul 25, 2023
Merged

[Contributor] 카드 UI 변경 #97

merged 3 commits into from
Jul 25, 2023

Conversation

wisemuji
Copy link
Member

Issue

Overview (Required)

  • 컨트리뷰터 카드 UI 변경된 디자인으로 수정
  • 컨트리뷰터 ID 영역은 고려하지 않음
    • Github API 기준으로 username과 id를 동시에 받아오려면 별도의 매핑 API 호출이 필요함
  • [designsystem] Placeholder AsyncImage 컴포저블 #88 이 머지되지 않아 이미지 영역은 Box로 잡아둠

Screenshot

@wisemuji wisemuji added the enhancement New feature or request label Jul 25, 2023
@wisemuji wisemuji requested a review from laco-dev July 25, 2023 15:14
@wisemuji wisemuji self-assigned this Jul 25, 2023
@wisemuji wisemuji merged commit 1529318 into droidknights:main Jul 25, 2023
@wisemuji wisemuji deleted the feature/#93 branch July 25, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laco-dev laco-dev Awaiting requested review from laco-dev

Assignees

@wisemuji wisemuji

Labels
2023 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Contributor] 카드 UI 변경
2 participants
@wisemuji @taehwandev