Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for COMMAND_INT #326

Closed
julianoes opened this issue Mar 16, 2018 · 3 comments
Closed

Support for COMMAND_INT #326

julianoes opened this issue Mar 16, 2018 · 3 comments
Labels
enhancement

Comments

@julianoes
Copy link
Collaborator

julianoes commented Mar 16, 2018 •
edited by thomasgubler
Loading

The Device class and MavlinkCommands class should support commands that use int32 for fields like latitude and longitude. This is e.g. required for ROI commands.

A starting point is here:
https://github.com/dronecore/DroneCore/blob/develop/core/mavlink_commands.h#L33-L35
@julianoes julianoes mentioned this issue Mar 16, 2018
Merged
@shakthi-prashanth-m
Copy link
Contributor

shakthi-prashanth-m commented Mar 23, 2018 •
edited
Loading

@julianoes we should also consider the ones that have few parameters than that of Command INT like this https://mavlink.io/en/messages/common.html#MAV_CMD_SET_CAMERA_MODE ?

@julianoes
Copy link
Collaborator Author

@shakthi-prashanth-m no these fields are just omitted in the docs.

@shakthi-prashanth-m shakthi-prashanth-m self-assigned this Apr 5, 2018
shakthi-prashanth-m pushed a commit that referenced this issue Apr 6, 2018
core, plugins: Add support for COMMAND_INT #326
9354ea0 
Adds new types `MAVLinkCommands::CmdInt` and `MAVLinkCommands::CmdLong`
types that abstract to those of MAVLink protocol:
http://mavlink.org/messages/common/#COMMAND_INT
http://mavlink.org/messages/common/#COMMAND_LONG

Also includes the changes in core and plugins, wherever these
commands are used. `COMMAND_INT` is used only in Gimbal plugin as of
now for `MAV_CMD_DO_SET_ROI_LOCATION`.
@shakthi-prashanth-m
Copy link
Contributor

Addreseed in #351 .

shakthi-prashanth-m pushed a commit that referenced this issue Apr 13, 2018
core, plugins: Add support for COMMAND_INT #326
c2ca30c 
Adds new types `MAVLinkCommands::CmdInt` and `MAVLinkCommands::CmdLong`
types that abstract to those of MAVLink protocol:
http://mavlink.org/messages/common/#COMMAND_INT
http://mavlink.org/messages/common/#COMMAND_LONG

Also includes the changes in core and plugins, wherever these
commands are used. `COMMAND_INT` is used only in Gimbal plugin as of
now for `MAV_CMD_DO_SET_ROI_LOCATION`.
@mrpollo mrpollo mentioned this issue Jun 5, 2018
Closed
rt-2pm2 pushed a commit to rt-2pm2/DronecodeSDK that referenced this issue Nov 27, 2018
core, plugins: Add support for COMMAND_INT mavlink#326
22ab197 
Adds new types `MAVLinkCommands::CmdInt` and `MAVLinkCommands::CmdLong`
types that abstract to those of MAVLink protocol:
http://mavlink.org/messages/common/#COMMAND_INT
http://mavlink.org/messages/common/#COMMAND_LONG

Also includes the changes in core and plugins, wherever these
commands are used. `COMMAND_INT` is used only in Gimbal plugin as of
now for `MAV_CMD_DO_SET_ROI_LOCATION`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julianoes @shakthi-prashanth-m