Add Follow me example #217

shakthi-prashanth-m · 2018-01-05T10:23:51Z

Adds FakeLocationProvider class which mocks platform-specific location provider. It uses Boost Asio for sending periodic report of fake location update. [Note: Boost is chosen for portability across major platforms]
Example registers with FakeLocationProvider for location updates and sends them to Follow Me plugin.
Fixes naming issue in Follow Me plug-in implementation.
Addresses FollowMeImpl::set_config() returns immediately though Device didn't confirm #221

Note: Algorithm that generates latitude, longitude to make drone revolve is rudimentary. As this just serves as an example, it should be fine. If there's a better algorithm, please feel free to replace it.

Thanks

julianoes · 2018-01-05T18:35:11Z

example/follow_me/fake_location_provider.cpp

+void FakeLocationProvider::request_location_updates(location_callback_t callback)
+{
+    location_callback_ = callback;
+    timer_.async_wait(boost::bind(&FakeLocationProvider::compute_next_location, this));


Do you really really need boost for this? I tried to keep everything to plain C++11, if at all possible, I'd vote to do this without boost.

I mean do you actually need to do it async? Or could you just use a loop where you set the location?

@julianoes I really like the async approach - it is far more realistic than just using a loop in the example. Is there something other than boost that could be used here?

In my opinion the example doesn't need to show how you could/should build this with async. It should only show how to use the DroneCore API. The simpler the better.

@julianoes A simple example in this case can show how the API is called, but now how it should be used. I think the way it is now will save readers time and energy. Your call though.

Thanks for the review @julianoes @hamishwillee. As discussed earlier our example should help application developers including Android, Windows, etc; I simulated approximate layout for the same. I tried simulating Android Location Provider: requestLocationUpdates.
Even Apple and Windows use this style. As mentioned earlier, I thought using Boost is portable way. I will try to check whether it can be done without Boost.

hamishwillee

Would be good if it could set a Config as well?

Otherwise I really like this.

shakthi-prashanth-m · 2018-01-09T07:32:31Z

@hamishwillee Sure, I can. I think Min height is most obvious among the Follow Me configuration. What do you think ?

hamishwillee · 2018-01-09T22:08:44Z

@hamishwillee Sure, I can. I think Min height is most obvious among the Follow Me configuration. What do you think ?

Yes. Perhaps even better, both that and the FollowDirection?

shakthi-prashanth-m · 2018-01-10T12:10:01Z

@hamishwillee I added in the example.

julianoes · 2018-01-10T18:30:35Z

@shakthi-prashanth-m if you rebase this on origin/develop and then force push I can merge it.

julianoes

I'm not sure why the. gitmodules and CMakeLists.txt changes are in this PR. Otherwise this is good to go in with the comment. Thanks @shakthi-prashanth-m.

1. Added methods for error handling. 2. Improved periodic location update logic. 3. Removed redundant header `cstdint`. 4. Removed log from FollowMe plugin. 5. Improved overall FollowMe example.

This change uses Boost APIs for registering with `FakeLocationProvider`. Removed location generator logic in example. Also, adds stop Follow Me before landing.

Experimental changes in Follow Me integration test was accidentally committed. This commit restore original.

Removed unused variables `curr_direction_s` & `new_direction_s` in `FollowMeImpl::receive_param_follow_direction()`.

This is done for auto-deletion of the location object when control goes out of scope.

1. Added methods for error handling. 2. Improved periodic location update logic. 3. Removed redundant header `cstdint`. 4. Removed log from FollowMe plugin. 5. Improved overall FollowMe example.

This change uses Boost APIs for registering with `FakeLocationProvider`. Removed location generator logic in example. Also, adds stop Follow Me before landing.

Experimental changes in Follow Me integration test was accidentally committed. This commit restore original.

1. This commit address DroneCore issue #221. 2. Corresponding changes (from #1 above) in integration tests & example. 3. Replaces boost::bind by std::bind. 4. Adds important note about using Boost in the example. 5. Adds debug_str to distinguish FollowMe plugin debug messages.

shakthi-prashanth-m · 2018-01-11T07:05:04Z

@julianoes Sorry CMakeLists.txt & .gitmodules changes were accidental. I removed it. Its built successfully and ready to be merged unless you or @hamishwillee have some comments on the latest commit.

Add set actuator

shakthi-prashanth-m requested a review from julianoes January 5, 2018 10:24

shakthi-prashanth-m assigned hamishwillee and unassigned hamishwillee Jan 5, 2018

shakthi-prashanth-m requested a review from hamishwillee January 5, 2018 10:24

shakthi-prashanth-m added enhancement plugins labels Jan 5, 2018

julianoes reviewed Jan 5, 2018

View reviewed changes

hamishwillee reviewed Jan 8, 2018

View reviewed changes

shakthi-prashanth-m mentioned this pull request Jan 10, 2018

FollowMeImpl::set_config() returns immediately though Device didn't confirm #221

Closed

julianoes approved these changes Jan 10, 2018

View reviewed changes

Shakthi Prashanth M added 14 commits January 11, 2018 11:20

follow_me example: add source and CMake file

07b3ad9

Add Follow Me example

bd60363

Simplify Follow Me example

f809bbf

1. Added methods for error handling. 2. Improved periodic location update logic. 3. Removed redundant header `cstdint`. 4. Removed log from FollowMe plugin. 5. Improved overall FollowMe example.

Add FakeLocationProvider class for Follow Me example

c8e9eb9

This change uses Boost APIs for registering with `FakeLocationProvider`. Removed location generator logic in example. Also, adds stop Follow Me before landing.

Restore Follow Me integration test

76a7ed4

Experimental changes in Follow Me integration test was accidentally committed. This commit restore original.

Rename follow_dist_m to follow_distance_m for consistency

9b69f0a

Remove unused variables in Follow Me plugin impl

baece82

Removed unused variables `curr_direction_s` & `new_direction_s` in `FollowMeImpl::receive_param_follow_direction()`.

Make location provider as smart pointer in Follow Me example.

1252e52

This is done for auto-deletion of the location object when control goes out of scope.

Rebase with develop

5d2a4d4

Add Follow Me example

092ab0a

Simplify Follow Me example

3d5256d

1. Added methods for error handling. 2. Improved periodic location update logic. 3. Removed redundant header `cstdint`. 4. Removed log from FollowMe plugin. 5. Improved overall FollowMe example.

Add FakeLocationProvider class for Follow Me example

586c3c5

This change uses Boost APIs for registering with `FakeLocationProvider`. Removed location generator logic in example. Also, adds stop Follow Me before landing.

Restore Follow Me integration test

5837ab8

Experimental changes in Follow Me integration test was accidentally committed. This commit restore original.

shakthi-prashanth-m force-pushed the follow_me_example branch from 71b9a2a to 3f1f06e Compare January 11, 2018 06:19

Add example description and correct note

88c7f93

Add spacing in the FollowMe example

bf1dc38

julianoes merged commit c134de0 into develop Jan 11, 2018

julianoes deleted the follow_me_example branch January 11, 2018 10:51

hamishwillee mentioned this pull request Jan 11, 2018

Add Follow Me example docs mavlink/MAVSDK-docs#80

Closed

shakthi-prashanth-m mentioned this pull request Jan 12, 2018

Follow Me has no example #189

Closed

mrpollo mentioned this pull request Jun 5, 2018

v1.0.0 Changelog scratchpad #417

Closed

dlech pushed a commit to dlech/MAVSDK that referenced this pull request Jan 14, 2022

Merge pull request mavlink#217 from amadoruavs/set-actuator

bc98c07

Add set actuator

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Follow me example #217

Add Follow me example #217

shakthi-prashanth-m commented Jan 5, 2018 •

edited

Loading

julianoes Jan 5, 2018

hamishwillee Jan 8, 2018

julianoes Jan 8, 2018

hamishwillee Jan 9, 2018

shakthi-prashanth-m Jan 9, 2018 •

edited

Loading

hamishwillee left a comment

shakthi-prashanth-m commented Jan 9, 2018

hamishwillee commented Jan 9, 2018

shakthi-prashanth-m commented Jan 10, 2018

julianoes commented Jan 10, 2018

julianoes left a comment

shakthi-prashanth-m commented Jan 11, 2018 •

edited

Loading

Add Follow me example #217

Add Follow me example #217

Conversation

shakthi-prashanth-m commented Jan 5, 2018 • edited Loading

julianoes Jan 5, 2018

Choose a reason for hiding this comment

hamishwillee Jan 8, 2018

Choose a reason for hiding this comment

julianoes Jan 8, 2018

Choose a reason for hiding this comment

hamishwillee Jan 9, 2018

Choose a reason for hiding this comment

shakthi-prashanth-m Jan 9, 2018 • edited Loading

Choose a reason for hiding this comment

hamishwillee left a comment

Choose a reason for hiding this comment

shakthi-prashanth-m commented Jan 9, 2018

hamishwillee commented Jan 9, 2018

shakthi-prashanth-m commented Jan 10, 2018

julianoes commented Jan 10, 2018

julianoes left a comment

Choose a reason for hiding this comment

shakthi-prashanth-m commented Jan 11, 2018 • edited Loading

shakthi-prashanth-m commented Jan 5, 2018 •

edited

Loading

shakthi-prashanth-m Jan 9, 2018 •

edited

Loading

shakthi-prashanth-m commented Jan 11, 2018 •

edited

Loading