Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FollowMeImpl::set_config() returns immediately though Device didn't confirm #221

Closed
shakthi-prashanth-m opened this issue Jan 10, 2018 · 2 comments
Closed

FollowMeImpl::set_config() returns immediately though Device didn't confirm #221

shakthi-prashanth-m opened this issue Jan 10, 2018 · 2 comments
Assignees
@shakthi-prashanth-m
Labels
enhancement plugins

Comments

@shakthi-prashanth-m
Copy link
Contributor

This is a known issue as mentioned in the code as FIXME.
Issue:
When an application calls FollowMe::set_config() requesting for config change, the API returns early before device confirmation for the same. It is not a fatal issue as it is most likely successful. However,
device confirmation may get delayed by few microseconds.
Solution:
Waiting for the device confirmation should happen from Follow Me plugin side.
@shakthi-prashanth-m shakthi-prashanth-m self-assigned this Jan 10, 2018
@shakthi-prashanth-m
Copy link
Contributor Author

#217 addresses this.

@shakthi-prashanth-m shakthi-prashanth-m changed the title FollowMeImpl::set_config returns immediately though Device didn't confirm FollowMeImpl::set_config() returns immediately though Device didn't confirm Jan 10, 2018
shakthi-prashanth-m pushed a commit that referenced this issue Jan 10, 2018
Fix plugin issues and improve example
b3ce763 
1. This commit address DroneCore issue #221.
2. Corresponding changes (from #1 above) in integration tests & example.
3. Replaces boost::bind by std::bind.
4. Adds important note about using Boost in the example.
5. Adds debug_str to distinguish FollowMe plugin debug messages.
@shakthi-prashanth-m shakthi-prashanth-m mentioned this issue Jan 10, 2018
Merged
shakthi-prashanth-m pushed a commit that referenced this issue Jan 11, 2018
Fix plugin issues and improve example
3f1f06e 
1. This commit address DroneCore issue #221.
2. Corresponding changes (from #1 above) in integration tests & example.
3. Replaces boost::bind by std::bind.
4. Adds important note about using Boost in the example.
5. Adds debug_str to distinguish FollowMe plugin debug messages.
julianoes pushed a commit that referenced this issue Jan 11, 2018
@julianoes
Fix plugin issues and improve example
55506fc 
1. This commit address DroneCore issue #221.
2. Corresponding changes (from #1 above) in integration tests & example.
3. Replaces boost::bind by std::bind.
4. Adds important note about using Boost in the example.
5. Adds debug_str to distinguish FollowMe plugin debug messages.
@shakthi-prashanth-m
Copy link
Contributor Author

Closing the issue, as #217 is merged. Thanks @julianoes.

@mrpollo mrpollo mentioned this issue Jun 5, 2018
Closed
rt-2pm2 pushed a commit to rt-2pm2/DronecodeSDK that referenced this issue Nov 27, 2018
@julianoes
Fix plugin issues and improve example
b8beca7 
1. This commit address DroneCore issue mavlink#221.
2. Corresponding changes (from mavlink#1 above) in integration tests & example.
3. Replaces boost::bind by std::bind.
4. Adds important note about using Boost in the example.
5. Adds debug_str to distinguish FollowMe plugin debug messages.
dlech pushed a commit to dlech/MAVSDK that referenced this issue Jan 14, 2022
@JonasVautherin
Merge pull request mavlink#221 from TSC21/pr-add_hold_action
d937b2b 
action: add request for vehicle to hold position (loiter)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shakthi-prashanth-m shakthi-prashanth-m

Labels
enhancement plugins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shakthi-prashanth-m