mavlink command fixes #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are a bunch of fixes to prevent promises getting set more than once which triggers an abort. This needs further cleanup, the changes are rather ugly.
This adds tests for the locked queue and also implements the mechanism to borrow and return an item from the queue. This allows to work on front without having to pop it.
This takes advantage of the new locked queue where we can borrow and return the front. Also, it removes the FAILED and DONE states which were not really having any purpose. This should properly fix the race conditions that we were seeing.
We now need to borrow and return the front. This should resolve some possible races for front.
It turns out that double unlocking a mutex is not possible on Windows. Therefore, we need to try to lock it before unlocking it.
It seems like with std::deferred this doesn't work as intended with older compilers.
julianoes
force-pushed
the
fix-sync-commands
branch
from
701e27a
to
30ed2d6
Compare
JonasVautherin
approved these changes
May 16, 2018
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
mavlink command fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a bunch of fixes to prevent promises getting set more than
once which triggers an abort.
This needs further cleanup, the changes are rather ugly.