Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mavlink command fixes #391

Merged
merged 9 commits into from
May 16, 2018
Merged

mavlink command fixes #391

merged 9 commits into from
May 16, 2018

Commits on May 14, 2018

  1. core: mavlink command sync fixes 

    These are a bunch of fixes to prevent promises getting set more than
once which triggers an abort.

This needs further cleanup, the changes are rather ugly.
    @julianoes
    julianoes committed May 14, 2018
    Configuration menu
    Copy the full SHA
    abb4765 View commit details
    Browse the repository at this point in the history

  2. core: add test for locked queue, add borrowing 

    This adds tests for the locked queue and also implements the mechanism
to borrow and return an item from the queue. This allows to work on
front without having to pop it.
    @julianoes
    julianoes committed May 14, 2018
    Configuration menu
    Copy the full SHA
    4e3dbfa View commit details
    Browse the repository at this point in the history

  3. mavlink_commands: adapt to new locked queue 

    This takes advantage of the new locked queue where we can borrow and
return the front. Also, it removes the FAILED and DONE states which were
not really having any purpose.

This should properly fix the race conditions that we were seeing.
    @julianoes
    julianoes committed May 14, 2018
    Configuration menu
    Copy the full SHA
    5183531 View commit details
    Browse the repository at this point in the history

  4. mavlink_parameters: adapt to new locked_queue API 

    We now need to borrow and return the front. This should resolve some
possible races for front.
    @julianoes
    julianoes committed May 14, 2018
    Configuration menu
    Copy the full SHA
    fc39f6c View commit details
    Browse the repository at this point in the history

  5. safe_queue: move initializers into declarations

    @julianoes
    julianoes committed May 14, 2018
    Configuration menu
    Copy the full SHA
    cb84292 View commit details
    Browse the repository at this point in the history

  6. locked_queue: fix unlocking on Windows 

    It turns out that double unlocking a mutex is not possible on Windows.
Therefore, we need to try to lock it before unlocking it.
    @julianoes
    julianoes committed May 14, 2018
    Configuration menu
    Copy the full SHA
    d4ae2fa View commit details
    Browse the repository at this point in the history

  7. locked_queue: wait longer to pass CI

    @julianoes
    julianoes committed May 14, 2018
    Configuration menu
    Copy the full SHA
    6176c89 View commit details
    Browse the repository at this point in the history

  8. core: fix style

    @julianoes
    julianoes committed May 14, 2018
    Configuration menu
    Copy the full SHA
    d270440 View commit details
    Browse the repository at this point in the history

  9. locked_queue: we can't use std::deferred 

    It seems like with std::deferred this doesn't work as intended with
older compilers.
    @julianoes
    julianoes committed May 14, 2018
    Configuration menu
    Copy the full SHA
    30ed2d6 View commit details
    Browse the repository at this point in the history