Skip to content

Commit

Permalink
Fix more sample app gradle config
Browse files Browse the repository at this point in the history
  • Loading branch information
joshafeinberg committed Nov 5, 2024
1 parent ee1e16e commit 5085435
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 13 deletions.
3 changes: 1 addition & 2 deletions sample/sample-app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ affectedTestConfiguration {
android {
namespace "com.dropbox.detector.sample"

compileSdkVersion 34
buildToolsVersion "30.0.2"
compileSdk 34

defaultConfig {
applicationId "com.dropbox.detector.sample"
Expand Down
3 changes: 2 additions & 1 deletion sample/sample-app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
android:roundIcon="@mipmap/ic_launcher_round"
android:supportsRtl="true"
android:theme="@style/Theme.Sample">
<activity android:name="com.dropbox.detector.sample.MainActivity">
<activity android:name="com.dropbox.detector.sample.MainActivity"
android:exported="true">
<intent-filter>
<action android:name="android.intent.action.MAIN" />

Expand Down
7 changes: 4 additions & 3 deletions sample/sample-core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,13 @@ affectedTestConfiguration {
}

android {
compileSdkVersion 30
buildToolsVersion "30.0.2"
namespace "com.dropbox.detector.sample_core"

compileSdk 34

defaultConfig {
minSdkVersion 23
targetSdkVersion 30
targetSdkVersion 34
versionCode 1
versionName "1.0"

Expand Down
3 changes: 1 addition & 2 deletions sample/sample-core/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.dropbox.detector.sample_core">
<manifest>

</manifest>

6 changes: 3 additions & 3 deletions sample/sample-util/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ affectedTestConfiguration {
}

android {
compileSdkVersion 30
buildToolsVersion "30.0.2"
namespace "com.dropbox.detector.sample_util"
compileSdk 34

defaultConfig {
minSdkVersion 23
targetSdkVersion 30
targetSdkVersion 34
versionCode 1
versionName "1.0"

Expand Down
3 changes: 1 addition & 2 deletions sample/sample-util/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.dropbox.detector.sample_util">
<manifest>

</manifest>

0 comments on commit 5085435

Please sign in to comment.