Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation to existing unittest2pytest project #3

Open
The-Compiler opened this issue Mar 15, 2016 · 5 comments
Open

Relation to existing unittest2pytest project #3

The-Compiler opened this issue Mar 15, 2016 · 5 comments

Comments

@The-Compiler
Copy link

There is already an existing unittest2pytest project under the pytest-dev umbrella by @htgoebel, which has the same name and works via lib2to3 as well.

Unfortunately, that's quite confusing - and I'm wondering, what's the reason Dropbox started their own converter rather than using the existing one? 😉

@auvipy
Copy link

auvipy commented Apr 1, 2016

same question fro me too. I'm gonna convert django unit tests to pytest tests. which should I use then?

@nipunn1313
Copy link
Contributor

Hey guys. Thanks for bringing this up. Honest truth is that we didn't know it was there when we wrote it. Was actually written around the same time (~Oct 2015). We came up with the name after the fact (turns out at least 2 people independently thought it was a good name :)) and it happens to collide with an existing project. Took a brief look at both projects and they are similar, but subtly different in how/where they work.

Perhaps we can try to merge the functionality of the projects. Or just have two implementations of similar things. Will have to look into it more. Happy to take any suggestions.

@The-Compiler
Copy link
Author

Thanks for replying! IMHO, if @htgoebel agrees, it'd be best to merge them. I think having two projects with the same goal, each with their own subtle benefits/drawbacks, doesn't benefit anyone here.

But all of that is of course up to @htgoebel and you - I'm afraid I won't have the time to help getting those merged. I just thought it was a good idea of bringing it up. 😄

@htgoebel
Copy link

htgoebel commented Apr 5, 2016

but subtly different in how/where they work.

Well, they are simply fixing different cases :-)

You are warmly welcome to contribute your fixes to unittest2pytest project under the pytest-dev umbrella. I suggest merging there, since this is where people will look for it.

adamchainz added a commit to adamchainz/dropbox-unittest2pytest that referenced this issue May 25, 2016
We were using `unittest2pytest` but due to googling and confusion didn't realize we were using the pytest-dev package from PyPI whilst looking at the source of this project. Adding a header to point to `unittest2pytest` will help future travellers.

Relates to dropbox#3.
@nipunn1313
Copy link
Contributor

For now I just went ahead and renamed this project and merged in @adamchainz's readme clarification. I'll continue redirecting people to the pytest-dev project which looks like it's going to get more love.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants