-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Action instead of Kotlin lambda. #5
Conversation
5bf06e5
to
e4e41e1
Compare
This is awesome! Thanks for fixing the Groovy syntax issues with this! Do we need another Gradle wrapper? Can't we run tasks from the root? : dependency-guard-gradle-plugin ? If we do need the wrapper can we use symlinks to the root gradlew and other wrapper files? |
@@ -0,0 +1,5 @@ | |||
distributionBase=GRADLE_USER_HOME | |||
distributionPath=wrapper/dists | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-bin.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need it, symlinks would keep this on 7.4.2 like the other.
Will do a proper look over tomorrow after I am back on a computer and not on my phone. Thanks again! |
Failing with an API check (predictably):
|
I wouldn't recommend symlinks because they won't work on Windows. I didn't even try to create the wrapper. It just sort of happened. In retrospect, I'm not sure how. Maybe when I imported it into IDEA? The reason I was running tasks from the plugin directory was because that's where the |
} | ||
plugins { | ||
id 'com.gradle.enterprise' version '3.10' | ||
//id 'com.dropbox.dependency-guard' version '$pluginVersion' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it should have been deleted. Because this PR uses withPluginClasspath()
, we don't need this. Just something I was playing with originally and forgot to fully delete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll delete this!
mavenCentral() | ||
} | ||
plugins { | ||
id 'com.gradle.enterprise' version '3.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most people don't have gradle enterprise, do we need this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That actually publishes the tests to the public scans server. But no, it's not necessary. It is sometimes useful for debugging why a test fails by looking at the build scan for it.
Merging for progress and since this is still a snapshot. I'll clean up the tests in CI and link to that in a few. |
Removed the extra gradle wrapper here: #6 Will just push the removal of the comment to |
Two commits:
Action
interface for better DSL support.