Fix: Uses Provider<ResolvedComponentResult> as input to Task #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handstandsam
force-pushed
the
0.4.0-fix
branch
from
294b917 to
69202fe
Compare
handstandsam
commented
Jan 23, 2023
| @@ -10,7 +10,6 @@ class GradleVersionArgumentsProvider : ArgumentsProvider { | |||
|
|
|||
| override fun provideArguments(context: ExtensionContext?): Stream<out Arguments> = Stream | |||
| .of( | |||
| ParameterizedPluginArgs(gradleVersion = GradleVersion.version("7.3.3"), withConfigurationCache = false), | |||
There was a problem hiding this comment.
Test fails for 7.3 because resolutionRoot is not available in this version.
handstandsam
commented
Jan 23, 2023
| internal const val DEPENDENCY_GUARD_TASK_NAME = "dependencyGuard" | ||
|
|
||
| internal const val DEPENDENCY_GUARD_BASELINE_TASK_NAME = "dependencyGuardBaseline" | ||
| } | ||
|
|
||
| override fun apply(target: Project) { | ||
| val extension = target.extensions.create( | ||
| DEPENDENCY_GUARD_TASK_NAME, | ||
| DEPENDENCY_GUARD_EXTENSION_NAME, |
There was a problem hiding this comment.
This change is not required in this diff, but is zero risk and slightly more explicit.
handstandsam
commented
Jan 23, 2023
| appendLine("") | ||
| val availableConfigNames = availableConfigurations | ||
| .filter { isClasspathConfig(it) } | ||
| } else { |
There was a problem hiding this comment.
We were using the return at the end of the if block, but if/else reads better IMO as this is an exahaustive if/else
handstandsam
commented
Jan 23, 2023
| @@ -19,8 +20,8 @@ internal val Project.projectConfigurations: ConfigurationContainer | |||
| configurations | |||
| } | |||
|
|
|||
| internal fun ConfigurationContainer.getResolvedComponentResult(name: String): ResolvedComponentResult = this | |||
| internal fun ConfigurationContainer.getResolvedComponentResult(name: String): Provider<ResolvedComponentResult> = this | |||
There was a problem hiding this comment.
Using recommended pattern in Config Cache Documentation: https://docs.gradle.org/current/userguide/configuration_cache.html
handstandsam
commented
Jan 23, 2023
| @@ -57,7 +58,7 @@ internal abstract class DependencyGuardListTask : DefaultTask() { | |||
| abstract val projectPath: Property<String> | |||
|
|
|||
| @get:Input | |||
| abstract val monitoredConfigurationsMap: MapProperty<DependencyGuardConfiguration, ResolvedComponentResult> | |||
| abstract val monitoredConfigurationsMap: MapProperty<DependencyGuardConfiguration, Provider<ResolvedComponentResult>> | |||
There was a problem hiding this comment.
Using recommended pattern in Config Cache Documentation: https://docs.gradle.org/current/userguide/configuration_cache.html
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following documentation on config cache https://docs.gradle.org/current/userguide/configuration_cache.html
Hopefully fixes #67 and #68
Chose to drop support for Gradle 7.3.x.
resolutionRootwas unavailable prior to Gradle 7.4.