FIX: Config Cache - TreeTask & ListTask #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress Using Directories as output correctly
…nly important previously for the Tree task when we delegated to Gradle to create the file. We have the value in memory we can use to do comparisions
handstandsam
commented
Jan 23, 2023
| @@ -14,7 +14,6 @@ internal class DependencyGuardListReportWriter( | |||
| * @return Whether changes were detected | |||
| */ | |||
| internal fun writeReport( | |||
| buildDirOutputFile: File, | |||
There was a problem hiding this comment.
This is a legacy artifact from the original Tree Diff practices where we would delegate to the Gradle Dependencies task, and then have the output file be the input for this task.
This is no longer required. We have the contents of the newly computed dependency list in memory, and we can compare with that.
handstandsam
force-pushed
the
issue-69
branch
from
12d2389 to
5f09f3b
Compare
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found more issues with config cache, so worked on that.
List Task:
@get:Input abstract val projectDirectory: DirectoryProperty->@get:OutputDirectory abstract val projectDirectoryDependenciesDir: DirectoryPropertyTree Task:
Projectwas being held in a var which breaks config cache. That has been fixed.Targets #67, #68, #69