Prevent UI thread from blocking during batch upload #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for putting this together! |
|
This was reported as a bug a long time ago: #221 |
roostr
force-pushed
the
fix/batch-upload-blocks-main-thread
branch
from
284a20f to
454c368
Compare
|
Updated to be rebased onto the latest master. |
The `batchUploadFiles` call does not report back a response until all uploads are completed. To do this, it calls sleep(1) while it waits for (1) everything to finish, (2) a cancel request, or (3) all uploads to finish. The calls to sleep(1) are made inside a `setResponseBlock` handler that is not passed a `queue` parameter. Because the queue isn't specified, it runs on the main thread. This causes apps that call this function to freeze on their main thread for a second. This patch makes a dedicated NSOperationQueue for monitoring the progress.
roostr
force-pushed
the
fix/batch-upload-blocks-main-thread
branch
from
454c368 to
6f32fb3
Compare
hector-dropbox
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
This is fairly simple and makes total sense. Thanks for putting this together @roostr! I'm sorry it took so long but like I mentioned in the issue I just started with Dropbox so I'm getting a bunch of stuff together. I won't be owning this SDK at the moment but I was the last one in the codebase. I'm happy to help elsewhere when I can!
|
Thank you, @hector-dropbox! |
|
@roostr Of course! Thanks for putting in the work to figure it out to begin with! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
batchUploadFilescall does not report back a response until all uploads are completed. To do this, it callssleep(1)while it waits for:The calls to
sleep(1)are made inside asetResponseBlockhandler that is not passed aqueueparameter. Because the queue isn't specified, it runs on the main thread. This causes apps that call this function to freeze on their main thread for a second.This patch makes a dedicated
NSOperationQueuefor monitoring the progress.