Skip to content
This repository has been archived by the owner on May 17, 2022. It is now read-only.

Upgrade Anvil and use the built-in mechanism to sync sources. #61

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Upgrade Anvil and use the built-in mechanism to sync sources. #61

merged 2 commits into from
Nov 8, 2021

Conversation

vRallev
Copy link
Contributor

@vRallev vRallev commented Nov 8, 2021

This feature requires a newer version of AGP, which itself requires a newer version of Gradle. Both dependencies have been upgraded as well.

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2021

CLA assistant check
All committers have signed the CLA.

…ature requires a newer version of AGP, which itself requires a newer version of Gradle. Both dependencies have been upgraded as well.
@changusmc
Copy link
Contributor

This feature requires a newer version of AGP, which itself requires a newer version of Gradle. Both dependencies have been upgraded as well.

Thanks for the AGP and Gradle bump, as well as the updated Anvil feature!

@vRallev vRallev requested a review from changusmc November 8, 2021 22:45
@@ -119,8 +119,6 @@ public final class com/dropbox/kaiken/scoping/BuildConfig {
public static final field BUILD_TYPE Ljava/lang/String;
public static final field DEBUG Z
public static final field LIBRARY_PACKAGE_NAME Ljava/lang/String;
public static final field VERSION_CODE I
public static final field VERSION_NAME Ljava/lang/String;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@changusmc I had to remove these. That was a change with AGP 4.1, see https://issuetracker.google.com/issues/154275579#comment3 Please take another look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you prefer, then I can bring back these values for each module. But to me it seems unnecessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay, I doubt people are using these APIs

@vRallev
Copy link
Contributor Author

vRallev commented Nov 8, 2021

I honestly don't know why this is:

debugAndroidTest > : No compatible devices connected.[TestRunner] FAILED 
Found 1 connected device(s), 0 of which were compatible.

I'm not too familiar with your setup, but I think the recommendation is to use a MacOS machine for instrumentation tests: ReactiveCircus/android-emulator-runner#62 Other than that I have no idea. I can run tests locally fine.

@changusmc
Copy link
Contributor

changusmc commented Nov 8, 2021

I honestly don't know why this is:

debugAndroidTest > : No compatible devices connected.[TestRunner] FAILED 
Found 1 connected device(s), 0 of which were compatible.

I'm not too familiar with your setup, but I think the recommendation is to use a MacOS machine for instrumentation tests: ReactiveCircus/android-emulator-runner#62 Other than that I have no idea. I can run tests locally fine.

We started seeing this recently, so it's not due to your changes. I'll verify locally and merge this.

I'll make the change to our CI to use MacOS separately from this.

@changusmc changusmc mentioned this pull request Nov 8, 2021
@changusmc changusmc merged commit fe69fd6 into dropbox:main Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants