-
Notifications
You must be signed in to change notification settings - Fork 12
Upgrade Anvil and use the built-in mechanism to sync sources. #61
Conversation
…ature requires a newer version of AGP, which itself requires a newer version of Gradle. Both dependencies have been upgraded as well.
Thanks for the AGP and Gradle bump, as well as the updated Anvil feature! |
…E. They're meaningless for library modules.
@@ -119,8 +119,6 @@ public final class com/dropbox/kaiken/scoping/BuildConfig { | |||
public static final field BUILD_TYPE Ljava/lang/String; | |||
public static final field DEBUG Z | |||
public static final field LIBRARY_PACKAGE_NAME Ljava/lang/String; | |||
public static final field VERSION_CODE I | |||
public static final field VERSION_NAME Ljava/lang/String; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@changusmc I had to remove these. That was a change with AGP 4.1, see https://issuetracker.google.com/issues/154275579#comment3 Please take another look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you prefer, then I can bring back these values for each module. But to me it seems unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay, I doubt people are using these APIs
I honestly don't know why this is:
I'm not too familiar with your setup, but I think the recommendation is to use a MacOS machine for instrumentation tests: ReactiveCircus/android-emulator-runner#62 Other than that I have no idea. I can run tests locally fine. |
We started seeing this recently, so it's not due to your changes. I'll verify locally and merge this. I'll make the change to our CI to use MacOS separately from this. |
This feature requires a newer version of AGP, which itself requires a newer version of Gradle. Both dependencies have been upgraded as well.