Fix "Add getProtocols method"
#1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is declared in ConnectionFactory in Jetty 9.3.*. To be compatible with it, we should have a method with the same signature. We can't use a compile-time dependency on Jetty 9.3.*, because it's compiled against Java 8, but codahale-metrics against Java 6. Therefore, we use reflection to access this method. Backport of #823
This was referenced Jan 5, 2017
Please provide a version of InstrumentedConnectionFactory that is compatible with Jetty 9.3.12
#1013
Closed
Merged
Closed
|
Thanks for this work! Any idea when this will land in a release? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is declared in ConnectionFactory in Jetty 9.3.*.
To be compatible with it, we should have a method with the same
signature.
We can't use a compile-time dependency on Jetty 9.3.*, because
it's compiled against Java 8, but codahale-metrics against Java 6.
Therefore, we use reflection to access this method.
Backport of #823