This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Add Advertisment Radar mode on Onboarding #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ COPYPASTE | jscpd | yes | no | 3.03s | |
| ✅ REPOSITORY | checkov | yes | no | 9.34s | |
| ✅ REPOSITORY | git_diff | yes | no | 0.03s | |
| ✅ REPOSITORY | secretlint | yes | no | 1.25s | |
| trivy | yes | 1 | 4.34s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by
|
Rendu : |
tjobit
reviewed
Jan 4, 2023
src/screens/Onboarding.js
Outdated
| <MaterialCommunityIcons name='bell-ring' size={24} style={{ color: Colors.purple1, paddingVertical: 3 }}/> | ||
| </View> | ||
| <View style={{ paddingHorizontal: 10 }}> | ||
| <Text style={{ ...Fonts.bold(13, Colors.purple1), paddingVertical: 5 }}>{'Ne consomme pas la batterie'}</Text> |
There was a problem hiding this comment.
Est-ce que "Ne consomme pas plus de batterie" ne serait pas mieux ? (c'est un détail)
celian-rib
suggested changes
Jan 4, 2023
There was a problem hiding this comment.
Le layout des icones + texte n'est pas correct
- Il te faut une View de ta liste = Une icone + son texte
- Il faudrait aussi que le texte "en savoir plus" soit fixé juste au dessus du bouton.
- Descend un peu la taille des icones et la taille du texte (font a 12 et icones a 22)
|
@AndreasCottet Tu termines la tâche ou je la fini ? |
|
Non tkt, je vais la finir. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.