Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toad-scheduler 1.6.1 → 2.3.0 (major) #388

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jun 7, 2023

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ toad-scheduler (1.6.1 → 2.3.0) · Repo

Release Notes

2.3.0

  • Support for retrieving a list of jobs (#183)
  • Return the current TaskId in Task handler (#180)

2.0.0

Features:

  • It is now possible to prevent task execution when execution time exceeds the re-execution period time (#114)

Breaking changes:

  • Node 10 support was dropped
  • Optional id parameter for jobs is now part of general options parameter. Like this:

Old version:

const job = new SimpleIntervalJob(
	{ seconds: 20, runImmediately: true },
	task, 'id_1',
);

New version:

const job = new SimpleIntervalJob(
	{ seconds: 20, runImmediately: true },
	task,
    { 
        id: 'id_1',
    }
);

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 20 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jun 7, 2023
@depfu depfu bot assigned drph4nt0m Jun 7, 2023
@depfu depfu bot requested a review from drph4nt0m June 7, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant