Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fragment and query in the fallback are ignored #19

Closed
hiroshige-g opened this issue May 4, 2018 · 0 comments
Closed

fragment and query in the fallback are ignored #19

hiroshige-g opened this issue May 4, 2018 · 0 comments
Assignees
@domenic
Labels
fallback syntax An issue with the syntax for falling back from a LAPI to a polyfill

Comments

@hiroshige-g
Copy link

In the proto-spec, the fallback is created from url's path[0], but this doesn't contain fragment/query.

So std:none|https://example.com/foo.js?bar#baz is resolved to https://example.com/foo.js, not https://example.com/foo.js?bar#baz.
@domenic domenic added the fallback syntax An issue with the syntax for falling back from a LAPI to a polyfill label May 7, 2018
domenic added a commit that referenced this issue May 7, 2018
@domenic
Fix accidental deletion of queries and fragments from the fallback
2e63311 
Closes #19. This technique is inspired by the data: URL processor's initial steps: https://fetch.spec.whatwg.org/commit-snapshots/7307d282dd7d1293d5697d63f73522007849e0db/#data-url-processor.
@domenic domenic mentioned this issue May 7, 2018
Merged
@domenic domenic self-assigned this May 7, 2018
domenic added a commit that referenced this issue Jun 18, 2018
@domenic
Fix accidental deletion of queries and fragments from the fallback
496a7a2 
Closes #19. This technique is inspired by the data: URL processor's initial steps: https://fetch.spec.whatwg.org/commit-snapshots/7307d282dd7d1293d5697d63f73522007849e0db/#data-url-processor.

Whether or not this technique is ideal, is an open question. See whatwg/url#385.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domenic domenic

Labels
fallback syntax An issue with the syntax for falling back from a LAPI to a polyfill
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @hiroshige-g