Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to set preserve-paths in dependency extras. #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tobbexiv
Copy link
Contributor

Issue:
I use a CMS which uses composer for extension management. In this implementation sometimes only the package name is known. Therefore the installed package is always wrapped in a new root package which has the package to install as dependency. Unfortunately this root package has none of the extra my package has and I can not change it. Therefore I can not use this plugin at the moment.

Solution:
Make it possible to get the preserve paths from the dependencies. To ensure that this causes no new issues, I added two new options. A package has to declare that his preserve paths should be read if it is used as dependency (preserve-paths-as-dependency). Additionally anyone who uses your plugin can override this behavior in your root package by setting preserve-paths-ignore-dependencies to true. In this case no information will be read for any of the dependencies.

I would be glad if you could include this, but it would also be ok for me if you decide that this is too specific and you do not want to have this change.

@derhasi
Copy link
Member

derhasi commented Feb 22, 2018

Sorry for not responding in this PR for such a long time. Put currently I don't fully grasp the implications of these changes, therefore I can't decide on it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants