Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugin-module related convenience methods #14

Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from

Conversation

bradjones1
Copy link
Member

...from the membership provider manager. These are useful in my use case since I'm using plugin module, but it's not core functionality and membership no longer has any dependency on plugin.

My IDE shows this as a safe delete/refactor but looking for a review as matter of course.

@bradjones1 bradjones1 self-assigned this Feb 14, 2017
@freelock
Copy link
Member

Hmm I'm thinking this is useful in my case, too... going to review further in a couple hours

@bradjones1
Copy link
Member Author

Think we can go ahead and remove these? I just moved the code to a site-specific module. While perhaps helpful, I don't think it belongs in Membership.

@freelock
Copy link
Member

freelock commented Mar 6, 2017

I did dig into the plugin system last week, and think I have my head around how it works, and where things go conceptually. But I'd really love to see how you're making use of this on your site-specific module.

I would tend to want things like this in the membership module, standard ways of finding/loading the plugin for a membership -- but if you have a better way that makes this all unnecessary, can you provide an example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants