-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiprice recipe #56
Conversation
* @param \Drupal\Core\Language\LanguageManagerInterface $language_manager | ||
* The language manager. | ||
*/ | ||
public function __construct(LanguageManagerInterface $language_manager) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on https://www.drupal.org/node/2831954#comment-11906059
and using the implementation suggested here, the tests won't work with $language_manager construct argument.
Please check my PR for the issue drupalcommerce/commerce#626
And maybe we could get the right solution for how this CommerceMulticurrencyResolver should be done
I think we should document a few different use cases for handling multicurrency. The most common use case I have is the following:
Could we document that behavior as well? |
A currency switcher is out of scope, but we can show how the geoip module can be used to get the ip country in the price resolver. |
I'm going to close this as it is pretty dated. And there are contrib incoming for this. Anyone is free to re-open a new PR to help cover this in the Developer Guide as "Multiple currency support" |
No description provided.