Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiprice recipe #56

Closed
wants to merge 6 commits into from

Conversation

GoZOo
Copy link

@GoZOo GoZOo commented Jan 27, 2017

No description provided.

* @param \Drupal\Core\Language\LanguageManagerInterface $language_manager
* The language manager.
*/
public function __construct(LanguageManagerInterface $language_manager) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on https://www.drupal.org/node/2831954#comment-11906059
and using the implementation suggested here, the tests won't work with $language_manager construct argument.

Please check my PR for the issue drupalcommerce/commerce#626
And maybe we could get the right solution for how this CommerceMulticurrencyResolver should be done

@luksak
Copy link

luksak commented Mar 2, 2017

I think we should document a few different use cases for handling multicurrency. The most common use case I have is the following:

  • Initially the currency is detected based on IP and set by zone/country
  • The user can switch currencies using a currency switcher

Could we document that behavior as well?

@bojanz
Copy link
Contributor

bojanz commented Mar 10, 2017

A currency switcher is out of scope, but we can show how the geoip module can be used to get the ip country in the price resolver.

@mglaman mglaman changed the base branch from master to sphinx-legacy September 10, 2017 03:37
@mglaman
Copy link
Collaborator

mglaman commented Oct 19, 2017

I'm going to close this as it is pretty dated. And there are contrib incoming for this. Anyone is free to re-open a new PR to help cover this in the Developer Guide as "Multiple currency support"

@mglaman mglaman closed this Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants