Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registration fields to stores for commerce tax zones. #846

Open
wants to merge 2 commits into
base: 8.x-2.x
Choose a base branch
from

Conversation

NickDickinsonWilde
Copy link
Contributor

@NickDickinsonWilde NickDickinsonWilde commented Dec 28, 2017

Problem:

The multiple tax zones in the Canadian taxes (likely other areas), may not all be applicable since there are varying levels of registration requirements (sales volumes) and you may (for example) be registered to collect GST (also automatically HST), but not BC PST or MB PST or QST etc. However, it is currently all or nothing as to zones.

Proposed Solution:

  • Create registration fields per tax zone/type - this has an added benefit of being an easy way to provide data for receipts/invoices for jurisdictions that require tax numbers being present on invoices/receipts
  • If present in tax zone definition, check for value on store as an extra registration confirmation.

To test, entity updates must be applied (drush entup). Only Canadian zones updated to use this - other zones will continue to work as previously.

Todo:

Testing, documentation, update function(?).

@NickDickinsonWilde
Copy link
Contributor Author

Tests failing is mostly whatever here - Mostly about feedback on the proposed solution right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant