Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test result xml escaping #13

Merged
merged 1 commit into from
Aug 20, 2013

Conversation

cyberwolf
Copy link
Contributor

If system-err or system-out contain characters which have a special meaning in XML (ampersand for example) then the generated test result XML will not be well-formed and result in parse errors when parsed.

@weitzman
Copy link
Member

Looks reasonable. Hopefully @msonnabaum can review it as he authored this code.

@ghost ghost assigned msonnabaum Aug 19, 2013
@msonnabaum
Copy link
Contributor

Yeah, looks reasonable. 👌

msonnabaum added a commit that referenced this pull request Aug 20, 2013
@msonnabaum msonnabaum merged commit d9e8ebc into drush-ops:8.x-6.x Aug 20, 2013
@cyberwolf
Copy link
Contributor Author

That went quick. Thanks guys!

@weitzman
Copy link
Member

Would be good if someone backported this to 7.x-5.x. Code changed a little so cherry-pick fails.

@cyberwolf cyberwolf deleted the test-result-xml-escaping branch August 31, 2013 20:11
@cyberwolf cyberwolf restored the test-result-xml-escaping branch August 31, 2013 20:11
serundeputy added a commit to serundeputy/drush that referenced this pull request Feb 21, 2016
11/add select support
this fixes: drush-ops#11 and drush-ops#12 Add support for --select, themes and layouts on the drush dl command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants