Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2528: Remove make. #2551

Closed
wants to merge 4 commits into from

Conversation

grasmash
Copy link
Contributor

@grasmash grasmash commented Jan 18, 2017

Leaving this here as a place holder. WIP and not ready to merge.

Todo:

  • Audit remaining make code with a code metrics tool to identify unused methods
  • Refactor tests
  • Modify make-convert command so that it uses D.O packagist and accompanying version constraints.
  • Audit make-convert command for deprecated functions

@grasmash grasmash force-pushed the issue-2528-remove-make branch from 9b9faa9 to 8caa241 Compare February 6, 2017 15:04
@grasmash
Copy link
Contributor Author

grasmash commented Feb 6, 2017

@weitzman

If we're going to continue supporting make-convert, then we need to support parsing ini files. That entails supporting make includes, recursive make files, remotely-hosted make files, etc.

There's a whole slew of functionality associated with parsing the various things that might be found in a make file.

Where do we draw the line? We could greatly simplify the codebase if we, for instance, said that we weren't going to support remote make file references.

@weitzman
Copy link
Member

weitzman commented Feb 6, 2017

Could folks use Drush8 to generate a lock file and then we convert that? That way we remove remote support. Or maybe enhance make-convert in 8.x and then we don't have to ship any make at all in Drush9?

@DocDJ
Copy link

DocDJ commented Feb 6, 2017 via email

@weitzman
Copy link
Member

weitzman commented Feb 28, 2017

I went with my last proposal. Folks can use make in Drush8 and convert using its make-convert when they are ready. See #2644

@weitzman weitzman closed this Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants