Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Drush's cache API. We no longer need to cache annotation parsing. #4965

Merged
merged 2 commits into from
Jan 1, 2022

Conversation

weitzman
Copy link
Member

No description provided.

@weitzman
Copy link
Member Author

weitzman commented Jan 1, 2022

This is green now, and the benchmarks look good. In fact, we are now faster without the cache for some reason. Its a mystery but I'm not gonna sweat it.

Branch Mean [ms] Min [ms] Max [ms] Relative
11.x 99.3 ± 4.2 92.2 112.6 1.05 ± 0.05
this PR 94.7 ± 2.1 91.7 99.8 1.00

This results from running hyperfine.

hyperfine --prepare "git checkout 11.x"  "./drush" \  
          --prepare "git checkout remove-cache-api" "./drush" --export-markdown results.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant