Restore SqlMariaDB override #6022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. If you have time to make a PR for 13.x that would be great. |
|
Currently there's no need, as 13.x still contains the original condition ( #5918 was never forward-ported ? ) |
|
OK, but you said you replaced another instance of mysqldump? That needs to go into 13.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5918 removed the call to
SqlMysql::make. Not sure why.Refixes #5777.
Additionally uses
dumpProgram()in an additional place.I'm not quite sure of how things get backported/forward ported or whatever. But it seems that #5918 was only applied to 12.x, not 13.x. Shout if I need to do something different.