-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added shuffle stack shortcut #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I've just got a few points/questions:
- The shortcut should be able to be changed in the options menu, under "Key Bindings".
- In CameraController, we may want to account for the fact the player might be hovering one, or multiple, pieces. If multiple pieces are being hovered, do we allow the player to shuffle all the stacks being hovered, or none at all?
- Should we only allow stacks to be shuffled when they are selected, rather than if the player is just hovering the mouse over them?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes needed for the options menu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think the tooltip needs to be a little bit more descriptive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'll test it on my end before approving (including the echo, I need to check the server is not overloaded with requests).
With the echo events, the client sends requests to the server around every 30ms, which is too fast in my opinion. We can either:
|
Screw this. Save idea for later. Will delete echo event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will test again before merging.
Fixes/Solves
Solved Issue-111
#111
For default key is Z