Use a BasicObject with method_missing for the builder API #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using define_singleton_method was bad because interferes with Ruby’s method caching.
| return super unless strategies.key?(name) | ||
|
|
||
| Injector.new(container, strategies[name]) | ||
| end |
There was a problem hiding this comment.
I know this is minor stuff but a simple if/else is always easier to parse with eyes than unless with return so:
if strategies.key?(name)
Injector.new(container, strategies[name])
else
super
endThere was a problem hiding this comment.
oh and method_missing should be private
There was a problem hiding this comment.
Yeah, you're right @solnic, that if/else is much clearer for a method with only 2 single-line pathways :)
|
It would be nice to actually have specs for method_missing behavior, it's always so easy to mess it up by an accident and libs with messed up method missing behavior may cause weird issues :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using define_singleton_method was bad because interferes with Ruby’s method caching.
I want to call out how I used
respond_to?here. BecauseBuilderis aBasicObjectsubclass now, and becauseBasicObjectdoes not even implement#respond_to?, I just implemented that directly and therefore didn't have to bother with#respond_to_missing?.