-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
push normal original args in kwargs strategy #32
Conversation
This looks like a nice enhancement! Would you mind adding a test to demonstrate/verify this extra behaviour in action? |
And I think if we wanted to put this in place, we should extend the same behaviour to the |
Hi @hbda, just checking in – were you interested in finishing this PR off? I left a couple of suggestions in my comments. |
Hi @timriley, I plan finish this request, but I didn`t have time. I will try to finish in the near future. |
@vladra well. I like it. Will you make request to my fork? Or I will copy your code? |
@hbda how about triggering tests once more? |
Can this be rebased on top of master? |
@solnic I rebased on top of master |
This looks good, thanks @hbda. I'll merge this now :) Would you mind letting me know what difficulty you had with the hash strategy, though? |
I'll aim to make a release next week, BTW. |
With a minor delay, I did this 🎉 |
In some cases it may be necessary to inject the classes with parameters in initializer. For example ActiveJob tasks. We improve kwargs strategy. It can work with parameterized initializers now.